philipnee commented on PR #12672: URL: https://github.com/apache/kafka/pull/12672#issuecomment-1276490455
Hey @guozhangwang , much thanks for the detail reviews, I tried to address some of the comments, please review them. In particular: 1. poll timeout logic 2. InterruptException handling (A side question here, when the BT got interrupted, shouldn't we terminate instead of swallowing the exception?) 3. Added a couple of tests to test the network client calls in a single poll. 4. I also removed the interface, originally I thought it would be helpful to write stubbed tests. I left the NOOP event there, but I agree we should move it once we've got an actual event implemented, which should happen soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
