dajac commented on code in PR #12741:
URL: https://github.com/apache/kafka/pull/12741#discussion_r994688472
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2142,7 +2142,6 @@ class ReplicaManager(val config: KafkaConfig,
): Unit = {
stateChangeLogger.info(s"Transitioning ${localFollowers.size} partition(s)
to " +
"local followers.")
- val shuttingDown = isShuttingDown.get()
Review Comment:
I suppose that you are saying that relying on `isShuttingDown` is brittle,
right? If that is the case, I do agree that relying on the broker state is
better. I think that we can refactor the remaining usages as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
