jsancio commented on code in PR #11023:
URL: https://github.com/apache/kafka/pull/11023#discussion_r995913999
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -778,9 +778,10 @@ public Future<RecordMetadata> send(ProducerRecord<K, V>
record) {
/**
* Asynchronously send a record to a topic and invoke the provided
callback when the send has been acknowledged.
* <p>
- * The send is asynchronous and this method will return immediately once
the record has been stored in the buffer of
+ * The send is asynchronous and this method will return immediately
(except for getting the topic metadata) once the record has been stored in the
buffer of
Review Comment:
@IvanVas, it looks like the code does block waiting for metadata information
on the cluster but only if it doesn't have the necessary information on the
topic. In other works the producer only blocks on the metadata response, if
this is the first record being sent to the cluster by this client for the given
topic.
How about encapsulating that in the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
