showuon commented on code in PR #12752:
URL: https://github.com/apache/kafka/pull/12752#discussion_r997795605
##########
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##########
@@ -246,6 +248,18 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(Errors.UNSUPPORTED_COMPRESSION_TYPE,
Errors.forCode(partitionProduceResponse2.errorCode))
}
+ @Test
+ @Timeout(value = 3, unit = TimeUnit.SECONDS)
+ def testSendWithBatchSizeZeroAndNoRecordKey(): Unit = {
Review Comment:
I think this is a better place for the test:
https://github.com/apache/kafka/blob/trunk/core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala#L50.
Besides, there's already a test for batch size 0. All you need to add is to
test with null key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
