gharris1727 opened a new pull request, #12806: URL: https://github.com/apache/kafka/pull/12806
Signed-off-by: Greg Harris <greg.har...@aiven.io> The existing hard-coded error bound in the test is inaccurate, such that certain patterns of request arrival cause this test to exceed the bound slightly. This has appeared in CI as a flakey test run which just barely exceeds the listed bound. Instead of a hard-coded error bound which can become inaccurate if the test's parameters change, compute the worst-case error bound based on the knowledge of the underlying windowing algorithm. Full derivation and explanation of the worst-case bound is provided in a comment in the util function. The bound is also unit tested in a mocked-time environment which simulates the behavior of the full SocketServer's throttle servo loop, simulating a connection flood with no delays. Also fix some IDE warnings, incorrect/misleading comments, and an AdminClient leak. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
