artemlivshits commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1012125206
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -390,7 +390,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* @param highWatermarkMetadata the suggested high watermark with offset
metadata
* @return the updated high watermark offset
Review Comment:
Javadoc.
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -379,7 +379,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* @param hw the suggested new value for the high watermark
* @return the updated high watermark offset
Review Comment:
We should update javadoc to doc the new return value.
##########
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##########
@@ -117,10 +127,11 @@ class ReplicaFetcherThread(name: String,
// For the follower replica, we do not need to keep its segment base
offset and physical position.
// These values will be computed upon becoming leader or handling a
preferred read replica fetch.
- val followerHighWatermark =
log.updateHighWatermark(partitionData.highWatermark)
+ val highWatermarkUpdate =
log.updateHighWatermark(partitionData.highWatermark)
+ info(s"follower high watermark: ${highWatermarkUpdate.highWatermark}")
Review Comment:
Should it be trace? This could flood the info log. Also looks like we
already log this info a few lines below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
