[GitHub] [kafka] mimaison commented on a diff in pull request #12804: [Minior] [Test] KAFKA-14344 : Build EmbeddedKafkaCluster with common configs used for all clients

[GitBox]

mimaison commented on code in PR #12804:
URL: https://github.com/apache/kafka/pull/12804#discussion_r1012744812


##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java:
##########
@@ -106,12 +106,20 @@ public class EmbeddedKafkaCluster {
     private final String[] currentBrokerLogDirs;
     private final boolean hasListenerConfig;
 
+    final Map<String, String> additionalClientConfigs;

Review Comment:
   What about using `clientConfigs`? If you agree let's rename the setters too.



##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java:
##########
@@ -435,7 +445,9 @@ public Admin createAdminClient(Properties 
adminClientConfig) {
             adminClientConfig.put(SslConfigs.SSL_TRUSTSTORE_PASSWORD_CONFIG, 
((Password) 
brokerConfig.get(SslConfigs.SSL_TRUSTSTORE_PASSWORD_CONFIG)).value());
             
adminClientConfig.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, "SSL");
         }
-        return Admin.create(adminClientConfig);
+        Properties finalAdminConfig = 
Utils.mkProperties(additionalClientConfigs);

Review Comment:
   In `createConsumer()` and `createProducer()` we add the custom client config 
first, here we do it the other way around. Let use similar logic if we can



##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java:
##########
@@ -435,7 +445,9 @@ public Admin createAdminClient(Properties 
adminClientConfig) {
             adminClientConfig.put(SslConfigs.SSL_TRUSTSTORE_PASSWORD_CONFIG, 
((Password) 
brokerConfig.get(SslConfigs.SSL_TRUSTSTORE_PASSWORD_CONFIG)).value());
             
adminClientConfig.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, "SSL");
         }
-        return Admin.create(adminClientConfig);
+        Properties finalAdminConfig = 
Utils.mkProperties(additionalClientConfigs);

Review Comment:
   I wonder if we could also change the type of `adminClientConfig` to `Map` so 
it's similar to the other create methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org