dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1017672302
##########
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##########
@@ -135,6 +151,13 @@ class ReplicaFetcherThread(name: String,
logAppendInfo
}
+ private def completeDelayedFetchRequests(): Unit = {
+ if (partitionsWithNewHighWatermark.nonEmpty) {
+
replicaMgr.completeDelayedFetchRequests(partitionsWithNewHighWatermark.toSeq)
Review Comment:
Yeah, I agree with you. Perhaps, we could actually change the test to cope
with this instead of changing the main code. A potential solution is discussed
here:
https://stackoverflow.com/questions/50025561/matching-mutable-object-without-argumentcaptor.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
