vamossagar12 commented on code in PR #12803: URL: https://github.com/apache/kafka/pull/12803#discussion_r1021016017
########## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ########## @@ -1046,7 +1047,18 @@ public <VR, KO, VO> KTable<K, VR> leftJoin(final KTable<KO, VO> other, return doJoinOnForeignKey(other, foreignKeyExtractor, joiner, TableJoined.with(null, null), materialized, true); } - @SuppressWarnings("unchecked") + private final Function<Optional<Set<Integer>>, Integer> getPartition = maybeMulticastPartitions -> { Review Comment: hey @YeonCheolGit . Thanks for the comment. Yeah it looks slightly loaded but the problem is we still want to retain the default behaviour ie when the underneath partitioner returns null, to invoke default partitioner. This class covers the 3 scenarios: https://github.com/apache/kafka/pull/12803/files#diff-36dd8c03fa5252dbd39042bb49a0d6272728fbd46459c6a45f5189fa59749b32R154-R169. Does that answer your question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org