C0urante commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1021729259
##########
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##########
@@ -138,7 +141,7 @@ public Connect startConnect(Map<String, String>
workerProps) {
// herder is stopped. This is easier than having to track and own the
lifecycle ourselves.
DistributedHerder herder = new DistributedHerder(config, time, worker,
kafkaClusterId, statusBackingStore, configBackingStore,
- advertisedUrl.toString(), connectorClientConfigOverridePolicy,
sharedAdmin);
+ advertisedUrl.toString(), restClient,
connectorClientConfigOverridePolicy, sharedAdmin, restClient);
Review Comment:
I think it's more natural to close it in the herder, primarily because of
the difference you've noted (where the shared admin client isn't used directly
by the herder, but the REST client is).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
