[GitHub] [kafka] showuon commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

[GitBox]

showuon commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r1022364377


##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java:
##########
@@ -270,7 +270,6 @@ public void testRemovingWorker() throws Exception {
                 WORKER_SETUP_DURATION_MS, "Connect and tasks are imbalanced 
between the workers.");
     }
 
-    @Ignore // TODO: To be re-enabled once we can make it less flaky 
(KAFKA-12495, KAFKA-12283)

Review Comment:
   @vamossagar12 , in L191, there's also a disabled test, I think after this 
patch, they should be reliable.



##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java:
##########
@@ -270,7 +270,6 @@ public void testRemovingWorker() throws Exception {
                 WORKER_SETUP_DURATION_MS, "Connect and tasks are imbalanced 
between the workers.");
     }
 
-    @Ignore // TODO: To be re-enabled once we can make it less flaky 
(KAFKA-12495, KAFKA-12283)

Review Comment:
   @vamossagar12 , in L191, there's also a disabled test, I think after this 
patch, they should be reliable. Please enable it, too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org