omkreddy commented on code in PR #12843:
URL: https://github.com/apache/kafka/pull/12843#discussion_r1023127960
##########
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala:
##########
@@ -200,11 +150,23 @@ abstract class EndToEndAuthorizationTest extends
IntegrationTestHarness with Sas
*/
@BeforeEach
override def setUp(testInfo: TestInfo): Unit = {
+
+ // The next two configuration parameters enable ZooKeeper secure ACLs
+ // and sets the Kafka authorizer, both necessary to enable security.
+ this.serverConfig.setProperty(KafkaConfig.ZkEnableSecureAclsProp, "true")
+ this.serverConfig.setProperty(KafkaConfig.AuthorizerClassNameProp,
authorizerClass.getName)
+
+ // Set the specific principal that can update ACLs.
+ this.serverConfig.setProperty(AclAuthorizer.SuperUsersProp,
kafkaPrincipal.toString)
+
super.setUp(testInfo)
+
+ val superuserAdminClient = createSuperuserAdminClient()
Review Comment:
Do we need to create `AclClusterAction, AclAlter` acls? since kafkaPrincipal
is super user, we dont need these acls.
##########
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala:
##########
@@ -64,15 +63,10 @@ import scala.jdk.CollectionConverters._
* SaslTestHarness here directly because it extends QuorumTestHarness, and we
* would end up with QuorumTestHarness twice.
*/
+@Timeout(60)
Review Comment:
why do we need Timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
