ijuma commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1026569181
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -214,14 +214,14 @@ object TestUtils extends Logging {
enableToken: Boolean = false,
numPartitions: Int = 1,
defaultReplicationFactor: Short = 1,
- startingIdNumber: Int = 0
- ): Seq[Properties] = {
+ startingIdNumber: Int = 0,
+ enableFetchFromFollower: Boolean = false): Seq[Properties] = {
Review Comment:
This method has far too many parameters, it doesn't make sense to add
parameters for every single possible configuration. Instead, you can add
whatever configuration you want to the returned `Properties` instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
