jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1026950932
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -1157,6 +1164,7 @@ object KafkaConfig { * KRaft mode configs. */ .define(MetadataSnapshotMaxNewRecordBytesProp, LONG, Defaults.MetadataSnapshotMaxNewRecordBytes, atLeast(1), HIGH, MetadataSnapshotMaxNewRecordBytesDoc) + .define(MetadataMaxSnapshotIntervalMsProp, LONG, Defaults.MetadataMaxSnapshotIntervalMs, atLeast(0), HIGH, MetadataMaxSnapshotIntervalMsDoc) Review Comment: A value of zero disables time based snapshots. I have this wording in the properties description: > A value of zero disables time based snapshot generation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org