cmccabe commented on code in PR #12928: URL: https://github.com/apache/kafka/pull/12928#discussion_r1036500418
########## metadata/src/main/java/org/apache/kafka/migration/MigrationRecoveryState.java: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.migration; + +import java.util.Objects; + +/** + * Persistent state needed to recover an ongoing migration. This data is stored in ZooKeeper under the "/migration" + * ZNode and is recovered by the active KRaft controller following an election. The absence of this data in ZK indicates + * that no migration has been started. + */ +public class MigrationRecoveryState { + + public static final MigrationRecoveryState EMPTY = new MigrationRecoveryState(-1, -1, -1, -1, -1, -1, -1); + + private final int kraftControllerId; + + private final int kraftControllerEpoch; + + private final long kraftMetadataOffset; + + private final long kraftMetadataEpoch; Review Comment: this should be an `int` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org