[GitHub] [kafka] cmccabe commented on a diff in pull request #12958: MINOR: Move dynamic config logic to DynamicConfigPublisher

[GitBox]

cmccabe commented on code in PR #12958:
URL: https://github.com/apache/kafka/pull/12958#discussion_r1041503192


##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -71,7 +71,7 @@ class BrokerServer(
   val initialOfflineDirs: Seq[String],
 ) extends KafkaBroker {
   val threadNamePrefix = sharedServer.threadNamePrefix
-  val config = sharedServer.config
+  val config = new KafkaConfig(sharedServer.sharedServerConfig.props, false, 
None)

Review Comment:
   Good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org