mjsax commented on code in PR #12944:
URL: https://github.com/apache/kafka/pull/12944#discussion_r1042536401
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1076,7 +1082,12 @@ public class StreamsConfig extends AbstractConfig {
Type.LONG,
null,
Importance.LOW,
- WINDOW_SIZE_MS_DOC);
+ WINDOW_SIZE_MS_DOC)
+ .define(DEFAULT_CLIENT_SUPPLIER_CONFIG,
Review Comment:
nit: we keep the configs grouped by priority and order alphabetically within
each group. Can we more this accordingly?
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1727,6 +1738,15 @@ public static Set<String>
verifyTopologyOptimizationConfigs(final String config)
return verifiedConfigs;
}
+ /**
+ * Return configured KafkaClientSupplier
+ * @return Configured KafkaClientSupplier
+ */
+ public KafkaClientSupplier getKafkaClientSupplier() {
Review Comment:
Thanks. Can you send a follow up email to the vote thread, calling out the
change?
We don't need to re-vote but if anybody would have an objection, we need to
give them a chance to race it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
