cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1042760995
##########
clients/src/main/resources/common/message/EnvelopeRequest.json:
##########
@@ -16,10 +16,11 @@
{
"apiKey": 58,
"type": "request",
- "listeners": ["controller"],
+ "listeners": ["controller", "zkBroker"],
"name": "EnvelopeRequest",
// Request struct for forwarding.
- "validVersions": "0",
+ // Version 1 adds the envelope request support to ZK brokers as well.
+ "validVersions": "0-1",
Review Comment:
hmm, I don't think this needs a version bump.
Even if we did the version bump, if a ZK-based broker sent a version 0
request it would work fine, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
