cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046455192
##########
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##########
@@ -355,6 +375,13 @@ class ZkMetadataCache(brokerId: Int, metadataVersion:
MetadataVersion, brokerFea
case id if id < 0 => None
case id => Some(id)
}
+ val kraftControllerIdOpt = updateMetadataRequest.kraftControllerId()
match {
+ case id if id < 0 => None
+ case id => Some(id)
+ }
+ if (controllerIdOpt.nonEmpty && kraftControllerIdOpt.nonEmpty) {
Review Comment:
This isn't an error, right? It's possible for both of them to be -1... Like
sometimes we are in the middle of electing a new controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
