C0urante commented on code in PR #12947: URL: https://github.com/apache/kafka/pull/12947#discussion_r1047800524
########## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java: ########## @@ -37,98 +34,65 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.net.URI; -import java.util.Arrays; -import java.util.Collections; import java.util.Map; /** * <p> - * Command line utility that runs Kafka Connect as a standalone process. In this mode, work is not - * distributed. Instead, all the normal Connect machinery works within a single process. This is - * useful for ad hoc, small, or experimental jobs. - * </p> - * <p> - * By default, no job configs or offset data is persistent. You can make jobs persistent and - * fault tolerant by overriding the settings to use file storage for both. + * Command line utility that runs Kafka Connect as a standalone process. In this mode, work (connectors and tasks) is not + * distributed. Instead, all the normal Connect machinery works within a single process. This is useful for for development + * and testing Kafka Connect on a local machine. Review Comment: I don't know the history here, but if I had to guess, two possibilities come to mind (which are not mutually exclusive): - Offsets are persisted for source connectors in order to provide symmetry between source and sink (since sink connector offsets are stored by default as consumer offsets in both standalone and distributed mode, which causes them to persist beyond the lifetime of any single worker) - Standalone mode may originally not have supported the REST API, in which case, the assumption would be that the configs are already stored on disk somewhere in order to be passed to the worker on startup as filenames -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
