ableegoldman commented on code in PR #12985:
URL: https://github.com/apache/kafka/pull/12985#discussion_r1050225672
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -159,7 +159,8 @@ public <K, V> void send(final String topic,
final Set<Integer> multicastPartitions =
maybeMulticastPartitions.get();
if (multicastPartitions.isEmpty()) {
// If a record is not to be sent to any partition,
mark it as a dropped record.
- log.debug("Not sending the record with key {} , value
{} to any partition", key, value);
+ log.warn("Skipping record as partitioner returned
empty partitions. "
Review Comment:
Imo we shouldn't put anything that can potentially be logged for every
record above `TRACE` as a rule of thumb. We always get user complaints and have
to downgrade the logging level for these sort of things anyways. I would
suggest to go back to including the key and value but put it at TRACE instead.
Thoughts? @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
