[ 
https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651299#comment-17651299
 ] 

Ahmed Sobeh commented on KAFKA-6579:
------------------------------------

AbstractWindowBytesStoreTest was actually created at some point. Is this ticket 
still valid? [~guozhang] 

> Consolidate window store and session store unit tests into a single class
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-6579
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6579
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Ahmed Sobeh
>            Priority: Major
>              Labels: newbie, unit-test
>
> For key value store, we have a {{AbstractKeyValueStoreTest}} that is shared 
> among all its implementations; however for window and session stores, each 
> class has its own independent unit test classes that do not share the test 
> coverage. In fact, many of these test classes share the same unit test 
> functions (e.g. {{RocksDBWindowStoreTest}}, 
> {{CompositeReadOnlyWindowStoreTest}} and {{CachingWindowStoreTest}}).
> It is better to use the same pattern as for key value stores to consolidate 
> these test functions into a shared base class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to