jolshan commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055678738
########## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ########## @@ -128,10 +128,13 @@ class TransactionsExpirationTest extends KafkaServerTestHarness { producer.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic1, 0, "2", "2", willBeCommitted = false)) producer.flush() + TestUtils.waitUntilTrue(() => producerState.nonEmpty, s"Producer IDs for topic1 did not propagate quickly") + // Ensure producer IDs are added. val pState = producerState - assertEquals(1, pState.size) - val oldProducerId = pState(0).producerId + assertEquals(1, pState.size, s"No producer visible via admin api") Review Comment: To be clear though, the error should be with regards to the producer state not populating right? Not the admin client? But yeah, the new error message makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org