C0urante commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1060830766
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -780,6 +774,14 @@ protected void stopServices() {
}
}
+ // Timeout for herderExecutor to gracefully terminate is set to a value to
accommodate
+ // reading to the end of the config topic + successfully attempting to
stop all connectors and tasks and a buffer of 10s
+ private long getHerderExecutorTimeoutMs() {
Review Comment:
Nit: We don't use `get` in this code base
```suggestion
private long herderExecutorTimeoutMs() {
```
Also, is there a reason this has to be a separate method at all? It's only
called in one place right now and the logic isn't really complicated enough to
warrant isolated unit testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
