[GitHub] [kafka] cmccabe commented on a diff in pull request #12998: KAFKA-14493: Introduce Zk to KRaft migration state machine STUBs in KRaft controller.

[GitBox]

cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062634566


##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -292,7 +292,7 @@ class BrokerLifecycleManager(
     }
     val data = new BrokerRegistrationRequestData().
         setBrokerId(nodeId).
-        setIsMigratingZkBroker(isZkBroker).
+        
setMigratingZkBrokerEpoch(zkBrokerEpochSupplier.map(_.apply()).getOrElse(-1)).

Review Comment:
   again, I would really like to distinguish between the "not zk broker" and 
"zk broker doesn't have a broker epoch for some reason" cases
   
   so if we are a zk broker but don't know the broker epoch for some reason we 
should throw an exception or something (or just retry)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org