ijuma commented on code in PR #13096:
URL: https://github.com/apache/kafka/pull/13096#discussion_r1066626422
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -483,7 +483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
case (topicPartition, partitionData) =>
try {
if (partitionData.committedMetadata() != null
- && partitionData.committedMetadata().length >
config.offsetMetadataMaxSize)
+ &&
partitionData.committedMetadata().lengthCompare(config.offsetMetadataMaxSize) >
0)
Review Comment:
`committedMetadata` returns a `String`, so this change doesn't seem like an
improvement. Similar comment for other similar changes where the underlying
collection is _not_ a Scala List.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
