ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1069827409
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -42,7 +43,7 @@ class BrokerMetadataListener(
val snapshotter: Option[MetadataSnapshotter],
brokerMetrics: BrokerServerMetrics,
_metadataLoadingFaultHandler: FaultHandler
-) extends RaftClient.Listener[ApiMessageAndVersion] with KafkaMetricsGroup {
+) extends RaftClient.Listener[ApiMessageAndVersion] with Logging {
Review Comment:
`KafkaMetricsGroup` wasn't used here.
##########
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##########
@@ -69,7 +68,7 @@ object ZkAdminManager {
class ZkAdminManager(val config: KafkaConfig,
val metrics: Metrics,
val metadataCache: MetadataCache,
- val zkClient: KafkaZkClient) extends Logging with
KafkaMetricsGroup {
+ val zkClient: KafkaZkClient) extends Logging {
Review Comment:
`KafkaMetricsGroup` wasn't used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
