gharris1727 commented on code in PR #13084:
URL: https://github.com/apache/kafka/pull/13084#discussion_r1072856520
##########
tests/kafkatest/tests/connect/connect_rest_test.py:
##########
@@ -90,7 +90,8 @@ def test_rest_api(self, connect_protocol, metadata_quorum):
self.cc.set_configs(lambda node:
self.render("connect-distributed.properties", node=node))
self.cc.set_external_configs(lambda node:
self.render("connect-file-external.properties", node=node))
- self.cc.start()
+ self.logger.info("Waiting till Connect REST server is listening")
+ self.cc.start(mode=ConnectServiceBase.STARTUP_MODE_LISTEN)
Review Comment:
I think this is unnecessary for the stabilization fix, and actually weakens
the test. Because this is actually creating the connectors in distributed mode,
I think it would be smart to wait for the cluster to actually join the cluster.
So we can revert these two lines and leave it as it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
