dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073333332
########## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ########## @@ -511,4 +532,57 @@ class GroupCoordinatorAdapter( future } + + override def partitionFor(groupId: String): Int = { Review Comment: It works before this patch because we were still using both the adapter and the old coordinator. The goal of all this work is to put the group coordinator behind an interface so that we can swap the implementation later on. `partitionFor` is exposed by the group coordinator so we have to add it to the interface as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org