jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080653448
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##########
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override def partitionFor(groupId: String): Int = {
+ coordinator.partitionFor(groupId)
+ }
+
+ override def onTransactionCompleted(
+ producerId: Long,
+ partitions: java.lang.Iterable[TopicPartition],
+ transactionResult: TransactionResult
+ ): Unit = {
+ coordinator.scheduleHandleTxnCompletion(
+ producerId,
+ partitions.asScala,
+ transactionResult
+ )
+ }
+
+ override def onPartitionsDeleted(
+ topicPartitions: util.List[TopicPartition],
+ bufferSupplier: BufferSupplier
+ ): Unit = {
+ coordinator.handleDeletedPartitions(topicPartitions.asScala,
RequestLocal(bufferSupplier))
Review Comment:
also any reason for the change from request local as a parameter to creating
it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
