divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1082615267
##########
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##########
@@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buffer, byte messageVer
public InputStream wrapForInput(ByteBuffer buffer, byte
messageVersion, BufferSupplier decompressionBufferSupplier) {
return ZstdFactory.wrapForInput(buffer, messageVersion,
decompressionBufferSupplier);
}
+
+ @Override
+ public int getRecommendedDOutSize() {
+ return 16 * 1024; // 16KB
Review Comment:
This will be picked up as a separate follow-up PR:
https://issues.apache.org/jira/browse/KAFKA-14634
I decided to keep it separate is to introduce fewer changes at a time and
measure their impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]