Hangleton commented on code in PR #13162: URL: https://github.com/apache/kafka/pull/13162#discussion_r1091027869
########## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ########## @@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel destChannel, * @param length The number of bytes to write * @throws IOException For any errors writing to the output */ - public static void writeTo(DataOutput out, ByteBuffer buffer, int length) throws IOException { + public static void writeTo(DataOutputStream out, ByteBuffer buffer, int length) throws IOException { if (buffer.hasArray()) { out.write(buffer.array(), buffer.position() + buffer.arrayOffset(), length); } else { - int pos = buffer.position(); - for (int i = pos; i < length + pos; i++) - out.writeByte(buffer.get(i)); + Channels.newChannel(out).write(buffer); Review Comment: Got it. Thanks. Would you have performance gains at a high-level, without sharing details on the application? Publicly available data showing the expectable gains would back up the PR further. Has this been discussed in the dev mailing list already? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org