cmccabe commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1091058054
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -521,7 +524,7 @@ protected Map<String, Integer> getNumPartitions(final
Set<String> topics,
for (final Map.Entry<String, KafkaFuture<TopicDescription>>
topicFuture : futures.entrySet()) {
final String topicName = topicFuture.getKey();
try {
- final TopicDescription topicDescription =
topicFuture.getValue().get();
+ final TopicDescription topicDescription =
topicFuture.getValue().get(Long.parseLong(DEFAULT_API_TIMEOUT_MS_CONFIG),
TimeUnit.MILLISECONDS);
Review Comment:
Do not put timeout parameters on Future.get. This will not abort the
operation. If you want timeouts, they should be done by adjusting your admin
client configuration parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
