hgeraldino opened a new pull request, #13193:
URL: https://github.com/apache/kafka/pull/13193

   This PR aligns the description for `source-record-write-rate` and 
`source-record-write-total` metrics, and excludes the filtered records from the 
metrics being published.
   
   Today, the `source-record-poll-[rate|total]` and 
`source-record-write-[rate|total]` are publishing similar values (except for 
cases where exceptions are thrown and retries are needed, which might throw off 
the rate a little bit). This means that it is not possible to find an accurate 
number of records written to Kafka by source connectors that use filter 
predicates.
   
   **Note**: the test for this PR was written on top of 
https://github.com/apache/kafka/pull/13191, so a rebase will be required after 
https://github.com/apache/kafka/pull/13191 is merged.
   
   Finally, I think it makes sense to publish a new metric with the number of 
filtered records, so I'll file a new KIP for it.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to