dajac commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1098775244
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -334,6 +334,29 @@ class ReplicaManager(val config: KafkaConfig,
topicPartitions.foreach(tp =>
delayedFetchPurgatory.checkAndComplete(TopicPartitionOperationKey(tp)))
}
+ /**
+ * Registers the provided listener to the partition iff the partition is
online.
+ */
+ def maybeAddListener(partition: TopicPartition, listener:
PartitionListener): Boolean = {
+ getPartition(partition) match {
+ case HostedPartition.Online(partition) =>
+ partition.maybeAddListener(listener)
+ case _ =>
+ false
+ }
+ }
+
+ /**
+ * Removes the provided listener from the partition.
+ */
+ def removeListener(partition: TopicPartition, listener: PartitionListener):
Unit = {
+ getPartition(partition) match {
+ case HostedPartition.Online(partition) =>
+ partition.removeListener(listener)
+ case _ => // Ignore
Review Comment:
When the partition goes offline or is deleted, the `Partition` object no
longer exists so we cannot remove the listener from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
