dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099084820


##########
generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java:
##########
@@ -408,6 +410,23 @@ private void generateListenerTypesEnum() {
         buffer.printf("}%n");
     }
 
+    private void generateHighestStableVersion() {
+        buffer.printf("public short highestStableVersion(boolean 
enableUnstableLastVersion) {%n");

Review Comment:
   Yeah, you're right. I went with `highestSupportedVersion(boolean 
enableUnstableLastVersion)`. See my last commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to