vcrfxia commented on code in PR #13188: URL: https://github.com/apache/kafka/pull/13188#discussion_r1103079190
########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { Review Comment: > Can we add a test (maybe in a follow up PR, with retention time zero)? Yes, that's a good point. I'll do it in a follow-up PR because I think we'll need a minor code change as well in order to not instantiate the segments store in this scenario. > it seems we don't test if delete() does return the right "old value"; can we also add some tests for it? Added a new `shouldDelete()`. ########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { + + private static final String STORE_NAME = "myversionedrocks"; + private static final String METRICS_SCOPE = "versionedrocksdb"; + private static final long HISTORY_RETENTION = 300_000L; + private static final long SEGMENT_INTERVAL = HISTORY_RETENTION / 3; + private static final long BASE_TIMESTAMP = 10L; + private static final Serializer<String> STRING_SERIALIZER = new StringSerializer(); + private static final Deserializer<String> STRING_DESERIALIZER = new StringDeserializer(); + + private InternalMockProcessorContext context; + + private RocksDBVersionedStore store; + + @Before + public void before() { + context = new InternalMockProcessorContext<>( + TestUtils.tempDirectory(), + Serdes.String(), + Serdes.String(), + new StreamsConfig(StreamsTestUtils.getStreamsConfig()) + ); + context.setTime(BASE_TIMESTAMP); + + store = new RocksDBVersionedStore(STORE_NAME, METRICS_SCOPE, HISTORY_RETENTION, SEGMENT_INTERVAL); + store.init((StateStoreContext) context, store); + } + + @After + public void after() { + store.close(); + } + + @Test + public void shouldPutLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP + 1); + + verifyGetValueFromStore("k", "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 1, "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 2, "v2", BASE_TIMESTAMP + 1); + } + + @Test + public void shouldPutNullAsLatest() { + putToStore("k", null, BASE_TIMESTAMP); Review Comment: This test is for validating that the store is able to handle a tombstone as the first thing put to the store (and continue to insert earlier records out-of-order afterwards). There are other tests (e.g., `shouldPutRepeatTimestampAsLatest()` and `shouldPutRepeatTimestamps()`) which test the scenario you've requested. ########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { + + private static final String STORE_NAME = "myversionedrocks"; + private static final String METRICS_SCOPE = "versionedrocksdb"; + private static final long HISTORY_RETENTION = 300_000L; + private static final long SEGMENT_INTERVAL = HISTORY_RETENTION / 3; + private static final long BASE_TIMESTAMP = 10L; + private static final Serializer<String> STRING_SERIALIZER = new StringSerializer(); + private static final Deserializer<String> STRING_DESERIALIZER = new StringDeserializer(); + + private InternalMockProcessorContext context; + + private RocksDBVersionedStore store; + + @Before + public void before() { + context = new InternalMockProcessorContext<>( + TestUtils.tempDirectory(), + Serdes.String(), + Serdes.String(), + new StreamsConfig(StreamsTestUtils.getStreamsConfig()) + ); + context.setTime(BASE_TIMESTAMP); + + store = new RocksDBVersionedStore(STORE_NAME, METRICS_SCOPE, HISTORY_RETENTION, SEGMENT_INTERVAL); + store.init((StateStoreContext) context, store); + } + + @After + public void after() { + store.close(); + } + + @Test + public void shouldPutLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP + 1); + + verifyGetValueFromStore("k", "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 1, "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 2, "v2", BASE_TIMESTAMP + 1); Review Comment: > User can not also query using "future timestamp" "can not" -> "can now". Yup! ########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { + + private static final String STORE_NAME = "myversionedrocks"; + private static final String METRICS_SCOPE = "versionedrocksdb"; + private static final long HISTORY_RETENTION = 300_000L; + private static final long SEGMENT_INTERVAL = HISTORY_RETENTION / 3; + private static final long BASE_TIMESTAMP = 10L; + private static final Serializer<String> STRING_SERIALIZER = new StringSerializer(); + private static final Deserializer<String> STRING_DESERIALIZER = new StringDeserializer(); + + private InternalMockProcessorContext context; + + private RocksDBVersionedStore store; + + @Before + public void before() { + context = new InternalMockProcessorContext<>( + TestUtils.tempDirectory(), + Serdes.String(), + Serdes.String(), + new StreamsConfig(StreamsTestUtils.getStreamsConfig()) + ); + context.setTime(BASE_TIMESTAMP); + + store = new RocksDBVersionedStore(STORE_NAME, METRICS_SCOPE, HISTORY_RETENTION, SEGMENT_INTERVAL); + store.init((StateStoreContext) context, store); + } + + @After + public void after() { + store.close(); + } + + @Test + public void shouldPutLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP + 1); + + verifyGetValueFromStore("k", "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 1, "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 2, "v2", BASE_TIMESTAMP + 1); + } + + @Test + public void shouldPutNullAsLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP + 1); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 2); + } + + @Test + public void shouldPutOlderWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderNullWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutOlderNullWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutRepeatTimestampAsLatest() { + putToStore("k", "to_be_replaced", BASE_TIMESTAMP); + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); + + putToStore("k", null, BASE_TIMESTAMP); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + + putToStore("k", null, BASE_TIMESTAMP); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); + } + + @Test + public void shouldPutRepeatTimestamps() { + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 10); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 1); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL + 10); + putToStore("k", null, SEGMENT_INTERVAL + 5); + putToStore("k", "vp5", SEGMENT_INTERVAL + 5); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 5); + putToStore("k", "vn5", SEGMENT_INTERVAL - 5); + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", "vn6", SEGMENT_INTERVAL - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 30); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 15); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 6, "vp5", SEGMENT_INTERVAL + 5); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn5", SEGMENT_INTERVAL - 5); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 6, "vn6", SEGMENT_INTERVAL - 6); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 8); + } + + @Test + public void shouldPutIntoMultipleSegments() { + putToStore("k", null, SEGMENT_INTERVAL - 20); + putToStore("k", "vn10", SEGMENT_INTERVAL - 10); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL + 1); + putToStore("k", "vp10", SEGMENT_INTERVAL + 10); + putToStore("k", null, SEGMENT_INTERVAL + 20); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 30); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 15, "vp10", SEGMENT_INTERVAL + 10); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 5); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn10", SEGMENT_INTERVAL - 10); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 15); + } + + @Test + public void shouldMoveRecordToOlderSegmentDuringPut() { + putToStore("k", "vp20", SEGMENT_INTERVAL + 20); + putToStore("k", "vp10", SEGMENT_INTERVAL + 10); + putToStore("k", "vn10", SEGMENT_INTERVAL - 10); + putToStore("k", "vn2", SEGMENT_INTERVAL - 2); + putToStore("k", "vn1", SEGMENT_INTERVAL - 1); + putToStore("k", "vp1", SEGMENT_INTERVAL + 1); + + verifyGetValueFromStore("k", "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 30, "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 15, "vp10", SEGMENT_INTERVAL + 10); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 5, "vp1", SEGMENT_INTERVAL + 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL, "vn1", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 1, "vn1", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 2, "vn2", SEGMENT_INTERVAL - 2); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn10", SEGMENT_INTERVAL - 10); + } + + @Test + public void shouldMoveRecordToOlderSegmentWithNullsDuringPut() { + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", null, SEGMENT_INTERVAL + 10); + putToStore("k", "vp5", SEGMENT_INTERVAL + 5); + putToStore("k", "vn5", SEGMENT_INTERVAL - 5); + putToStore("k", "vn6", SEGMENT_INTERVAL - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 30); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 15); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 6, "vp5", SEGMENT_INTERVAL + 5); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn5", SEGMENT_INTERVAL - 5); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 6, "vn6", SEGMENT_INTERVAL - 6); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 8); + } + + @Test + public void shouldFallThroughToExistingOlderSegmentAsLatestDuringPut() { + putToStore("k", null, SEGMENT_INTERVAL - 5); + putToStore("k", "vn6", SEGMENT_INTERVAL - 6); + putToStore("k", "vp20", SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL + 10); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", "vn2", SEGMENT_INTERVAL - 2); + + verifyGetValueFromStore("k", "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 30, "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 12); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 2, "vn2", SEGMENT_INTERVAL - 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 5); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 6, "vn6", SEGMENT_INTERVAL - 6); + } + + @Test + public void shouldPutNonLatestTombstoneIntoNewSegmentWithValidTo() { + putToStore("k", "vp30", SEGMENT_INTERVAL + 30); + putToStore("k", null, SEGMENT_INTERVAL - 10); // this put should result in tombstone with validTo=SEGMENT_INTERVAL+30 Review Comment: No, this is not degenerate. It's not degenerate because there is a well-defined validTo in this case, from the record in the latest value store (`vp30` with timestamp `SEGMENT_INTERVAL + 30`). Degenerate segments only form if the latest value is a tombstone, which means there is no validTo we can use for the tombstone. ########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { + + private static final String STORE_NAME = "myversionedrocks"; + private static final String METRICS_SCOPE = "versionedrocksdb"; + private static final long HISTORY_RETENTION = 300_000L; + private static final long SEGMENT_INTERVAL = HISTORY_RETENTION / 3; + private static final long BASE_TIMESTAMP = 10L; + private static final Serializer<String> STRING_SERIALIZER = new StringSerializer(); + private static final Deserializer<String> STRING_DESERIALIZER = new StringDeserializer(); + + private InternalMockProcessorContext context; + + private RocksDBVersionedStore store; + + @Before + public void before() { + context = new InternalMockProcessorContext<>( + TestUtils.tempDirectory(), + Serdes.String(), + Serdes.String(), + new StreamsConfig(StreamsTestUtils.getStreamsConfig()) + ); + context.setTime(BASE_TIMESTAMP); + + store = new RocksDBVersionedStore(STORE_NAME, METRICS_SCOPE, HISTORY_RETENTION, SEGMENT_INTERVAL); + store.init((StateStoreContext) context, store); + } + + @After + public void after() { + store.close(); + } + + @Test + public void shouldPutLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP + 1); + + verifyGetValueFromStore("k", "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 1, "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 2, "v2", BASE_TIMESTAMP + 1); + } + + @Test + public void shouldPutNullAsLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP + 1); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 2); + } + + @Test + public void shouldPutOlderWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderNullWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutOlderNullWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutRepeatTimestampAsLatest() { + putToStore("k", "to_be_replaced", BASE_TIMESTAMP); + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); + + putToStore("k", null, BASE_TIMESTAMP); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + + putToStore("k", null, BASE_TIMESTAMP); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); + } + + @Test + public void shouldPutRepeatTimestamps() { + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 10); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 1); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL + 10); + putToStore("k", null, SEGMENT_INTERVAL + 5); + putToStore("k", "vp5", SEGMENT_INTERVAL + 5); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 5); + putToStore("k", "vn5", SEGMENT_INTERVAL - 5); + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", "vn6", SEGMENT_INTERVAL - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 30); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 15); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 6, "vp5", SEGMENT_INTERVAL + 5); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn5", SEGMENT_INTERVAL - 5); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 6, "vn6", SEGMENT_INTERVAL - 6); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 8); + } + + @Test + public void shouldPutIntoMultipleSegments() { + putToStore("k", null, SEGMENT_INTERVAL - 20); + putToStore("k", "vn10", SEGMENT_INTERVAL - 10); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL + 1); + putToStore("k", "vp10", SEGMENT_INTERVAL + 10); + putToStore("k", null, SEGMENT_INTERVAL + 20); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 30); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 15, "vp10", SEGMENT_INTERVAL + 10); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 5); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn10", SEGMENT_INTERVAL - 10); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 15); + } + + @Test + public void shouldMoveRecordToOlderSegmentDuringPut() { + putToStore("k", "vp20", SEGMENT_INTERVAL + 20); + putToStore("k", "vp10", SEGMENT_INTERVAL + 10); + putToStore("k", "vn10", SEGMENT_INTERVAL - 10); + putToStore("k", "vn2", SEGMENT_INTERVAL - 2); + putToStore("k", "vn1", SEGMENT_INTERVAL - 1); + putToStore("k", "vp1", SEGMENT_INTERVAL + 1); + + verifyGetValueFromStore("k", "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 30, "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 15, "vp10", SEGMENT_INTERVAL + 10); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 5, "vp1", SEGMENT_INTERVAL + 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL, "vn1", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 1, "vn1", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 2, "vn2", SEGMENT_INTERVAL - 2); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn10", SEGMENT_INTERVAL - 10); + } + + @Test + public void shouldMoveRecordToOlderSegmentWithNullsDuringPut() { + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", null, SEGMENT_INTERVAL + 10); + putToStore("k", "vp5", SEGMENT_INTERVAL + 5); + putToStore("k", "vn5", SEGMENT_INTERVAL - 5); + putToStore("k", "vn6", SEGMENT_INTERVAL - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 30); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 15); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 6, "vp5", SEGMENT_INTERVAL + 5); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn5", SEGMENT_INTERVAL - 5); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 6, "vn6", SEGMENT_INTERVAL - 6); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 8); + } + + @Test + public void shouldFallThroughToExistingOlderSegmentAsLatestDuringPut() { + putToStore("k", null, SEGMENT_INTERVAL - 5); + putToStore("k", "vn6", SEGMENT_INTERVAL - 6); + putToStore("k", "vp20", SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL + 10); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", "vn2", SEGMENT_INTERVAL - 2); + + verifyGetValueFromStore("k", "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 30, "vp20", SEGMENT_INTERVAL + 20); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL + 12); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 2, "vn2", SEGMENT_INTERVAL - 2); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 5); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 6, "vn6", SEGMENT_INTERVAL - 6); + } + + @Test + public void shouldPutNonLatestTombstoneIntoNewSegmentWithValidTo() { + putToStore("k", "vp30", SEGMENT_INTERVAL + 30); + putToStore("k", null, SEGMENT_INTERVAL - 10); // this put should result in tombstone with validTo=SEGMENT_INTERVAL+30 + putToStore("k", "vn5", SEGMENT_INTERVAL - 5); + putToStore("k", "vn1", SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL - 2); + + verifyGetValueFromStore("k", "vp30", SEGMENT_INTERVAL + 30); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL + 10, "vn1", SEGMENT_INTERVAL - 1); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 1, "vn1", SEGMENT_INTERVAL - 1); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 2); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 5, "vn5", SEGMENT_INTERVAL - 5); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 10); + } + + @Test + public void shouldGetFromOlderSegments() { + // use a different key to create three different segments + putToStore("ko", null, SEGMENT_INTERVAL - 10); + putToStore("ko", null, 2 * SEGMENT_INTERVAL - 10); + putToStore("ko", null, 3 * SEGMENT_INTERVAL - 10); + + // return null after visiting all segments + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 20); + + // insert data to create non-empty (first) segment + putToStore("k", "v", SEGMENT_INTERVAL - 20); + putToStore("k", null, SEGMENT_INTERVAL - 10); + + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 30); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 15, "v", SEGMENT_INTERVAL - 20); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 5); + + // insert data to create non-empty (third) segment + putToStore("k", "v2", 3 * SEGMENT_INTERVAL - 20); + putToStore("k", null, 3 * SEGMENT_INTERVAL - 10); + + // presence of non-empty later segment does not affect results of getting from earlier segment + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 30); + verifyTimestampedGetValueFromStore("k", SEGMENT_INTERVAL - 15, "v", SEGMENT_INTERVAL - 20); + verifyTimestampedGetNullFromStore("k", SEGMENT_INTERVAL - 5); + } + + @Test + public void shouldNotGetExpired() { Review Comment: Hm, I started adding a new test case for this but then realized we can't actually test this without querying the physical segments store itself. Say we try to set up the test like so: * put v1 with ts=0 * put v3 with ts=100 * advance stream time so ts=50 is expired * put v2 with ts=40, which updates the validTo of the first put to something expired Now what should the validation be? If we query at ts=40, of course we get null because everything prior to ts=50 is expired (the existing test already checks this). If we query at ts=60, of course we get v2 but this happens regardless of whether v1 is expired or not. So the only way to validate that v1 is actually expired is to check the underlying store, but that responsibility seems like it belongs with LogicalKeyValueSegmentsTest instead. ########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { + + private static final String STORE_NAME = "myversionedrocks"; + private static final String METRICS_SCOPE = "versionedrocksdb"; + private static final long HISTORY_RETENTION = 300_000L; + private static final long SEGMENT_INTERVAL = HISTORY_RETENTION / 3; + private static final long BASE_TIMESTAMP = 10L; + private static final Serializer<String> STRING_SERIALIZER = new StringSerializer(); + private static final Deserializer<String> STRING_DESERIALIZER = new StringDeserializer(); + + private InternalMockProcessorContext context; + + private RocksDBVersionedStore store; + + @Before + public void before() { + context = new InternalMockProcessorContext<>( + TestUtils.tempDirectory(), + Serdes.String(), + Serdes.String(), + new StreamsConfig(StreamsTestUtils.getStreamsConfig()) + ); + context.setTime(BASE_TIMESTAMP); + + store = new RocksDBVersionedStore(STORE_NAME, METRICS_SCOPE, HISTORY_RETENTION, SEGMENT_INTERVAL); + store.init((StateStoreContext) context, store); + } + + @After + public void after() { + store.close(); + } + + @Test + public void shouldPutLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP + 1); + + verifyGetValueFromStore("k", "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 1, "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 2, "v2", BASE_TIMESTAMP + 1); + } + + @Test + public void shouldPutNullAsLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP + 1); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 2); + } + + @Test + public void shouldPutOlderWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderNullWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutOlderNullWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutRepeatTimestampAsLatest() { + putToStore("k", "to_be_replaced", BASE_TIMESTAMP); + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); + + putToStore("k", null, BASE_TIMESTAMP); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); Review Comment: Added (as above). ########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { + + private static final String STORE_NAME = "myversionedrocks"; + private static final String METRICS_SCOPE = "versionedrocksdb"; + private static final long HISTORY_RETENTION = 300_000L; + private static final long SEGMENT_INTERVAL = HISTORY_RETENTION / 3; + private static final long BASE_TIMESTAMP = 10L; + private static final Serializer<String> STRING_SERIALIZER = new StringSerializer(); + private static final Deserializer<String> STRING_DESERIALIZER = new StringDeserializer(); + + private InternalMockProcessorContext context; + + private RocksDBVersionedStore store; + + @Before + public void before() { + context = new InternalMockProcessorContext<>( + TestUtils.tempDirectory(), + Serdes.String(), + Serdes.String(), + new StreamsConfig(StreamsTestUtils.getStreamsConfig()) + ); + context.setTime(BASE_TIMESTAMP); + + store = new RocksDBVersionedStore(STORE_NAME, METRICS_SCOPE, HISTORY_RETENTION, SEGMENT_INTERVAL); + store.init((StateStoreContext) context, store); + } + + @After + public void after() { + store.close(); + } + + @Test + public void shouldPutLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP + 1); + + verifyGetValueFromStore("k", "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 1, "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 2, "v2", BASE_TIMESTAMP + 1); + } + + @Test + public void shouldPutNullAsLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP + 1); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 2); + } + + @Test + public void shouldPutOlderWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderNullWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutOlderNullWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutRepeatTimestampAsLatest() { + putToStore("k", "to_be_replaced", BASE_TIMESTAMP); + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); Review Comment: Sure, I've added this check into each of the verifications in this test. ########## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +import org.apache.kafka.common.serialization.Deserializer; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.processor.StateStoreContext; +import org.apache.kafka.streams.state.VersionedRecord; +import org.apache.kafka.test.InternalMockProcessorContext; +import org.apache.kafka.test.StreamsTestUtils; +import org.apache.kafka.test.TestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +public class RocksDBVersionedStoreTest { + + private static final String STORE_NAME = "myversionedrocks"; + private static final String METRICS_SCOPE = "versionedrocksdb"; + private static final long HISTORY_RETENTION = 300_000L; + private static final long SEGMENT_INTERVAL = HISTORY_RETENTION / 3; + private static final long BASE_TIMESTAMP = 10L; + private static final Serializer<String> STRING_SERIALIZER = new StringSerializer(); + private static final Deserializer<String> STRING_DESERIALIZER = new StringDeserializer(); + + private InternalMockProcessorContext context; + + private RocksDBVersionedStore store; + + @Before + public void before() { + context = new InternalMockProcessorContext<>( + TestUtils.tempDirectory(), + Serdes.String(), + Serdes.String(), + new StreamsConfig(StreamsTestUtils.getStreamsConfig()) + ); + context.setTime(BASE_TIMESTAMP); + + store = new RocksDBVersionedStore(STORE_NAME, METRICS_SCOPE, HISTORY_RETENTION, SEGMENT_INTERVAL); + store.init((StateStoreContext) context, store); + } + + @After + public void after() { + store.close(); + } + + @Test + public void shouldPutLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP + 1); + + verifyGetValueFromStore("k", "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 1, "v2", BASE_TIMESTAMP + 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP + 2, "v2", BASE_TIMESTAMP + 1); + } + + @Test + public void shouldPutNullAsLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP + 1); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP + 2); + } + + @Test + public void shouldPutOlderWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", "v2", BASE_TIMESTAMP - 2); + putToStore("k", "v1", BASE_TIMESTAMP - 1); + putToStore("k", "v4", BASE_TIMESTAMP - 4); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 1, "v1", BASE_TIMESTAMP - 1); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 2, "v2", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v4", BASE_TIMESTAMP - 4); + } + + @Test + public void shouldPutOlderNullWithNonNullLatest() { + putToStore("k", "v", BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetValueFromStore("k", "v", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "v", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutOlderNullWithNullLatest() { + putToStore("k", null, BASE_TIMESTAMP); + putToStore("k", null, BASE_TIMESTAMP - 2); + putToStore("k", null, BASE_TIMESTAMP - 1); + putToStore("k", null, BASE_TIMESTAMP - 4); + putToStore("k", "v3", BASE_TIMESTAMP - 3); + putToStore("k", "v5", BASE_TIMESTAMP - 5); + putToStore("k", null, BASE_TIMESTAMP - 6); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 1); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 2); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 3, "v3", BASE_TIMESTAMP - 3); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 4); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP - 5, "v5", BASE_TIMESTAMP - 5); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP - 6); + } + + @Test + public void shouldPutRepeatTimestampAsLatest() { + putToStore("k", "to_be_replaced", BASE_TIMESTAMP); + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); + + putToStore("k", null, BASE_TIMESTAMP); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + + putToStore("k", null, BASE_TIMESTAMP); + + verifyGetNullFromStore("k"); + verifyTimestampedGetNullFromStore("k", BASE_TIMESTAMP); + + putToStore("k", "b", BASE_TIMESTAMP); + + verifyGetValueFromStore("k", "b", BASE_TIMESTAMP); + verifyTimestampedGetValueFromStore("k", BASE_TIMESTAMP, "b", BASE_TIMESTAMP); + } + + @Test + public void shouldPutRepeatTimestamps() { + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 10); + putToStore("k", null, SEGMENT_INTERVAL - 10); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 1); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL - 1); + putToStore("k", null, SEGMENT_INTERVAL + 1); + putToStore("k", null, SEGMENT_INTERVAL + 10); + putToStore("k", null, SEGMENT_INTERVAL + 5); + putToStore("k", "vp5", SEGMENT_INTERVAL + 5); + putToStore("k", "to_be_replaced", SEGMENT_INTERVAL - 5); + putToStore("k", "vn5", SEGMENT_INTERVAL - 5); + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", null, SEGMENT_INTERVAL + 20); + putToStore("k", "vn6", SEGMENT_INTERVAL - 6); Review Comment: I added comments to the puts regarding why there are so many lines (they test different combinations of null vs non-null being replaced with null vs non-null, and also with timestamps across segments vs in the same segment vs the latest value store). I didn't add anything regarding the current state at each step since that feels a bit overkill. The way to figure out the end state is to ignore everything that says "to_be_replace" and then de-dup the few remaining rows. If we want to further improve readability, we can break this up into separate tests but my gut says that's unnecessary at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
