Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1104760648
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java:
##########
@@ -78,11 +89,18 @@ public OffsetCommitRequestData data() {
return data;
}
- public Map<TopicPartition, Long> offsets() {
+ public Map<TopicPartition, Long> offsets(TopicResolver topicResolver) {
Map<TopicPartition, Long> offsets = new HashMap<>();
for (OffsetCommitRequestTopic topic : data.topics()) {
+ String topicName = topic.name();
+
+ if (version() >= 9 && topicName == null) {
Review Comment:
Note 2: We could fail partially - just for the given topic entry - rather
than the entire response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
