[GitHub] [kafka] ijuma commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

[via GitHub]

ijuma commented on code in PR #13078:
URL: https://github.com/apache/kafka/pull/13078#discussion_r1104874450


##########
core/src/main/scala/kafka/log/ProducerStateManager.scala:
##########
@@ -504,7 +520,7 @@ class ProducerStateManager(
    * Truncate the producer id mapping and remove all snapshots. This resets 
the state of the mapping.
    */
   def truncateFullyAndStartAt(offset: Long): Unit = {
-    producers.clear()
+    removeProducerIds(producers.keySet)

Review Comment:
   Not true:
   
   ```java
   public void clear() {
           Node<K,V>[] tab;
           modCount++;
           if ((tab = table) != null && size > 0) {
               size = 0;
               for (int i = 0; i < tab.length; ++i)
                   tab[i] = null;
           }
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org