gharris1727 commented on code in PR #13178:
URL: https://github.com/apache/kafka/pull/13178#discussion_r1106151042
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java:
##########
@@ -134,9 +138,9 @@ public String version() {
@Override
public List<SourceRecord> poll() throws InterruptedException {
try {
- long deadline = System.currentTimeMillis() + interval.toMillis();
- while (!stopping && System.currentTimeMillis() < deadline) {
- offsetSyncStore.update(pollTimeout);
+ if (stopping.await(pollTimeout.toMillis(), TimeUnit.MILLISECONDS))
{
Review Comment:
The condition is correct, but i agree that changing this doesn't help very
much. I was mostly doing this to avoid the "busy loop" warning, but i think
that isn't really worth it, especially if we can have a follow-up that actually
improves the waiting behavior and eliminates that warning. Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
