mjsax commented on code in PR #13243:
URL: https://github.com/apache/kafka/pull/13243#discussion_r1106568364
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##########
@@ -297,6 +312,12 @@ void restoreBatch(final Collection<ConsumerRecord<byte[],
byte[]>> records) {
// records into memory. how high this memory amplification will be is
very much dependent
// on the specific workload and the value of the "segment interval"
parameter.
for (final ConsumerRecord<byte[], byte[]> record : records) {
+ if (record.timestamp() < streamTimeForRestore - gracePeriod) {
+ // record is older than grace period and was therefore never
written to the store
Review Comment:
Thanks. Makes sense.
I think it's ok to leave it as-is for now. But could you maybe file a Jira
ticket (with all the glory details) for tracking? Might be worth to do some
follow up work later to change it (but not worth to delay the KIP implemenation
at this point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
