vamossagar12 commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1430997152
> Hi @vamossagar12 this looks good, but I still think we should move `GetOffsetShellParsingTest` to `TopicPartitionFilterTest` removing any reference to `GetOffsetShell` (there is already a test for that) and create a new `PartitionFilterTest`, which should be similar to `TopicFilterTest`. Thanks @fvaleri . I tried doing this today. A problem that I see is that `GetOffsetShellParsingTest` makes use of 2 methods from `GetOffsetShell` namely `createTopicPartitionFilterWithTopicAndPartitionPattern` and `createTopicPartitionFilterWithPatternList`. Those 2 methods are also eventually used in `GetOffsetShell` when creating `topicPartitionFilter`. Ideally these 2 methods can reside in `ToolsUtils` and have both tests and `GetOffsetShell` reference it. I see there's also [Move GetOffsetShell to tools](https://issues.apache.org/jira/browse/KAFKA-14581). Can we do the move as part of that effort or here? WDYS? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
