jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107759481
########## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ########## @@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig, // this is an optimization: if the partitions are already in the metadata reply OK immediately Left(Errors.NONE) } else { - Right(coordinatorEpoch, txnMetadata.prepareAddPartitions(partitions.toSet, time.milliseconds())) + // If verifyOnly, we should have returned in the step above. If we didn't the partitions are not present in the transaction. + if (verifyOnly) { + Left(Errors.INVALID_TXN_STATE) Review Comment: You bring up good points and I can give more detailed response on partition level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org