mjsax commented on code in PR #13249: URL: https://github.com/apache/kafka/pull/13249#discussion_r1107868286
########## streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerializer.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import static org.apache.kafka.streams.kstream.internals.WrappingNullableUtils.initNullableSerializer; + +import java.nio.ByteBuffer; +import java.util.Map; +import java.util.Objects; +import org.apache.kafka.common.serialization.LongSerializer; +import org.apache.kafka.common.serialization.Serializer; +import org.apache.kafka.streams.kstream.internals.WrappingNullableSerializer; +import org.apache.kafka.streams.processor.internals.SerdeGetter; +import org.apache.kafka.streams.state.ValueAndTimestamp; +import org.apache.kafka.streams.state.internals.NullableValueAndTimestampSerde.BooleanSerde.BooleanSerializer; + +/** + * See {@link NullableValueAndTimestampSerde}. + */ +public class NullableValueAndTimestampSerializer<V> implements WrappingNullableSerializer<ValueAndTimestamp<V>, Void, V> { + public final Serializer<V> valueSerializer; + private final Serializer<Long> timestampSerializer; + private final Serializer<Boolean> booleanSerializer; + + NullableValueAndTimestampSerializer(final Serializer<V> valueSerializer) { + this.valueSerializer = Objects.requireNonNull(valueSerializer); + timestampSerializer = new LongSerializer(); + booleanSerializer = new BooleanSerializer(); + } + + @Override + public void configure(final Map<String, ?> configs, final boolean isKey) { + valueSerializer.configure(configs, isKey); + timestampSerializer.configure(configs, isKey); + booleanSerializer.configure(configs, isKey); + } + + @Override + public byte[] serialize(final String topic, final ValueAndTimestamp<V> data) { + if (data == null) { + return null; + } + final byte[] rawValue = valueSerializer.serialize(topic, data.value()); + final byte[] rawIsTombstone = booleanSerializer.serialize(topic, rawValue == null); + final byte[] rawTimestamp = timestampSerializer.serialize(topic, data.timestamp()); + + final byte[] nonNullRawValue = rawValue == null ? new byte[0] : rawValue; + return ByteBuffer + .allocate(rawTimestamp.length + rawIsTombstone.length + nonNullRawValue.length) Review Comment: Well, I would rather let it crash with an exception right here to surface a potential bug instead of trying to be resilient and mask a potential bug (that we might hit on de-serialization later, making it harder to figure out where it came from). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org