[GitHub] [kafka] guozhangwang commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

[via GitHub]

guozhangwang commented on code in PR #13025:
URL: https://github.com/apache/kafka/pull/13025#discussion_r1109175366


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##########
@@ -3159,7 +3159,7 @@ private void addRecord(final MockConsumer<byte[], byte[]> 
mockConsumer,
     }
 
     StreamTask activeTask(final TaskManager taskManager, final TopicPartition 
partition) {
-        final Stream<Task> standbys = 
taskManager.allTasks().values().stream().filter(Task::isActive);
+        final Stream<Task> standbys = 
taskManager.allOwnedTasks().values().stream().filter(Task::isActive);

Review Comment:
   For my understanding: why we need to change the callee here as well?



##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ReadOnlyTaskTest.java:
##########
@@ -41,7 +41,6 @@ class ReadOnlyTaskTest {
             add("changelogPartitions");
             add("commitRequested");
             add("isActive");
-            add("commitNeeded");

Review Comment:
   Good to know :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org