hachikuji commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1110441561
##########
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##########
@@ -23,17 +23,35 @@
// Version 2 adds the support for new error code PRODUCER_FENCED.
//
// Version 3 enables flexible versions.
- "validVersions": "0-3",
+ //
+ // Version 4 adds VerifyOnly field to check if partitions are already in
transaction and adds support to batch multiple transactions.
+ "validVersions": "0-4",
"flexibleVersions": "3+",
"fields": [
- { "name": "TransactionalId", "type": "string", "versions": "0+",
"entityType": "transactionalId",
+ { "name": "VerifyOnly", "type": "bool", "versions": "4+", "default": false,
Review Comment:
Yeah, interesting point. I could see moving `VerifyOnly` to the level of
`transactionalId`. An interesting corollary if we do batch both modes together
is that verify-only requests may end up blocking on replication even though we
are only checking the state in memory. This would kind of penalize old clients,
but maybe that's acceptable. Unless we used separate connections for each mode,
perhaps it is unavoidable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
