guozhangwang commented on code in PR #13228:
URL: https://github.com/apache/kafka/pull/13228#discussion_r1114660400
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -151,9 +202,18 @@ private void resumeTasks() {
}
}
- private void restoreTasks() {
+ private void pauseTasks() {
+ for (final Task task : updatingTasks.values()) {
Review Comment:
I think the perf impact should be small since pause/resume are not commonly
used, and if the named topology are not paused, then checking the status is
just a few cpu cycles.
Another motivation is that if we remove named topologies, than pausing /
resuming would always be impact on all tasks, in which case we could have a
simpler check (e.g. just check a single flag) which would be even cheaper. So
it's probably better to maintain the code layout in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
