rondagostino commented on code in PR #13280:
URL: https://github.com/apache/kafka/pull/13280#discussion_r1114692109
##########
metadata/src/main/java/org/apache/kafka/image/TopicsImage.java:
##########
@@ -38,15 +40,21 @@
*/
public final class TopicsImage {
public static final TopicsImage EMPTY =
- new TopicsImage(Collections.emptyMap(), Collections.emptyMap());
+ new TopicsImage(map(), map());
+
+ final ImMap<Uuid, TopicImage> topicsById;
+ final ImMap<String, TopicImage> topicsByName;
- private final Map<Uuid, TopicImage> topicsById;
- private final Map<String, TopicImage> topicsByName;
+ public TopicsImage(ImMap<Uuid, TopicImage> topicsById,
+ ImMap<String, TopicImage> topicsByName) {
+ this.topicsById = topicsById;
+ this.topicsByName = topicsByName;
+ }
- public TopicsImage(Map<Uuid, TopicImage> topicsById,
- Map<String, TopicImage> topicsByName) {
- this.topicsById = Collections.unmodifiableMap(topicsById);
- this.topicsByName = Collections.unmodifiableMap(topicsByName);
+ public TopicsImage including(TopicImage topic) {
Review Comment:
It is used from a test class in the `core` module so it needs to be public
:-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
