[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

[via GitHub]

Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1116204122


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -1369,7 +1387,7 @@ public void testJoinPrepareWithDisableAutoCommit() {
         try (ConsumerCoordinator coordinator = 
prepareCoordinatorForCloseTest(true, false, Optional.of("group-id"), true)) {
             coordinator.ensureActiveGroup();
 
-            prepareOffsetCommitRequest(singletonMap(t1p, 100L), Errors.NONE);
+            prepareOffsetCommitRequest(new 
OffsetCommitResponseSpec().expectedOffsets(singletonMap(t1p, 100L)));

Review Comment:
   Sure, I reverted this refactoring and use the response class instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org