showuon commented on code in PR #13304:
URL: https://github.com/apache/kafka/pull/13304#discussion_r1118032062
##########
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##########
@@ -202,7 +202,7 @@ final class KafkaMetadataLog private (
}
override def highWatermark: LogOffsetMetadata = {
- val LogOffsetSnapshot(_, _, hwm, _) = log.fetchOffsetSnapshot
+ val hwm = log.fetchOffsetSnapshot.highWatermark
Review Comment:
nice refactor!
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1112,7 +1079,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
new LogAppendInfo(firstOffset, lastOffset, lastLeaderEpochOpt,
maxTimestamp, offsetOfMaxTimestamp,
RecordBatch.NO_TIMESTAMP, logStartOffset, RecordConversionStats.EMPTY,
sourceCompression, targetCompression,
- shallowMessageCount, validBytesCount, monotonic, lastOffsetOfFirstBatch)
+ shallowMessageCount, validBytesCount, monotonic, lastOffsetOfFirstBatch,
Collections.emptyList[RecordError], null,
+ LeaderHwChange.NONE)
Review Comment:
Why do we need to explicitly set default value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
